Conversation
242ab7f to
8ee0006
Compare
|
Tested this locally and it worked as expected |
8ee0006 to
f99ec07
Compare
|
No breaking changes detected. |
c389a70 to
b1e2713
Compare
a96edc4 to
fc74aa3
Compare
fc74aa3 to
de23fd1
Compare
de23fd1 to
67ffaf4
Compare
|
thanks for including the sample images. I noticed that the Changelog entries are extremely long. I think we'll want to experiment with the prompt we're using to build those. |
| echo "Error: VERSION environment variable must be set" | ||
| echo "This script is intended to be called by the create-release-pr workflow" |
There was a problem hiding this comment.
should we print to stderr?
Please note this workflow does not generate any new changelog entries. This workflow simply takes the changelog entries from the unreleased section and puts them in the commit message and PR description for visibility (to recap what is going to be released). That is what you're seeing in the images I included. The long changelog entry you're referring to is a changelog entry for another workflow I added earlier. It's not LLM generated. The only thing the workflow in this PR is responsible for is updating the SDK version in the CHANGELOG and all other files that need the version number updated in preparation for the release. |
52e4efe to
23eaa26
Compare
yeah makes sense. I didn't think it was coming from this PR. It just looked long and agent generated. You hand crafted it though? |
| # Update docs/README.md | ||
| log_info "Updating docs/README.md..." | ||
| sed "s/^- Package version:.*/- Package version: $VERSION/" docs/README.md > docs/README.md.tmp && mv docs/README.md.tmp docs/README.md |
There was a problem hiding this comment.
Rather than duplicating the logic of copying the docs read me. I think we should create a new Makefile target like make docs and then call it from both the existing makefile target that uses it and here.
There was a problem hiding this comment.
Ah I understand now (I think)! I added a makefile target but please note I called it sync-readme. docs felt a bit too broad as there are many other docs files that don't get touched as part of this. Additionally, make docs sounds like we are copying README into docs/README, but it's the other way around. Let me know what you think!
There was a problem hiding this comment.
oh I see what's going on now. In the normal workflow, we update the internal/spec/config.yaml file and then run the client generation step (make generate-openapi-client). That step creates the client and docs which includes a README. We then shift some of the directories around including copying the README from the docs/README location to README. Should we actually just run the make generate-openapi-client change? After understanding this better, i see that pulling the moving of the README to a separate makefile target seems silly.
There was a problem hiding this comment.
Updated to run make generate-openapi-client. With this change, we no longer need to update README, docs/README, and pkg/client/configuration.go manually. Thanks for the suggestion
I did use claude to write it. It's the changelog entry for this PR. I'was just trying to say it's not autogenerated by a workflow based on any prompt. I can update the relevant PR to make the entry shorter but it's a one off |
cf22100 to
26a06db
Compare
26a06db to
4b5eccc
Compare
|
@fantapop I've updated the reusable action to remove changelog entries from the commit message body. Why: Commit message lines should be at most 72 characters, but changelog entries don't follow this rule. It would be unnecessarily complex to convert the changelog entries to wrap at 72 characters for the commit message. Since the individual commits already describe the changes and the changelog entries are visible in the PR description, the simpler approach is to use a hardcoded message format. Here's the PR: cockroachdb/actions#27 |
f49c201 to
5ec108f
Compare
ah I see. makes sense. we are planning to generate the changelog entry from claude though right? We should consider asking it to keep it brief. |
Add GitHub Actions workflow that automatically creates release PRs when pending-deploy-* branches are merged to main. The workflow updates go.mod for major version changes, updates config.yaml with the new version, and regenerates the OpenAPI client to automatically update all generated files (README.md, docs/README.md, pkg/client/configuration.go). Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
5ec108f to
03ec431
Compare
fantapop
left a comment
There was a problem hiding this comment.
This is looking good to me. It seems like we could get away with logging to stdout for info lines and stderr for warn and error lines.
| # Output an informational message to stderr | ||
| log_info() { | ||
| local message="$1" | ||
| echo "$message" >&2 | ||
| } |
There was a problem hiding this comment.
It's surprising to me that all these need to go to stderr. Is it because some script that's using it, needs stdout for communicating between processes?
Added GitHub Actions workflow that automatically creates release PRs when pending-deploy-* branches are merged to main. The workflow uses the reusable workflow from cockroachdb/actions and updates all version references across the SDK including CHANGELOG.md, go.mod, config files, and documentation.